Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Send and Recv futures #33

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Add Send and Recv futures #33

merged 2 commits into from
Feb 17, 2021

Conversation

yoshuawuyts
Copy link
Member

Closes #22. cc/ @taiki-e I'm pretty sure the pin-project-lite impls here aren't needed, but my brain is too mush to think of how to do it using the pin-utils variants. Thanks!

@Kestrer
Copy link

Kestrer commented Feb 17, 2021

You don't need even need pin-utils - just unconditionally implement Unpin for the futures, and everything should just work.

@yoshuawuyts
Copy link
Member Author

@Kestrer ohh, yeah good point. Updated the PR, and think it's all like it should be now 😁

@yoshuawuyts yoshuawuyts merged commit a9787b9 into master Feb 17, 2021
@yoshuawuyts yoshuawuyts deleted the send-recv-types branch February 17, 2021 19:43
@yoshuawuyts
Copy link
Member Author

Published as v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use a manual Future impl for methods
2 participants